poetry icon indicating copy to clipboard operation
poetry copied to clipboard

Add test coverage for tests/helpers.py

Open abn opened this issue 11 months ago • 7 comments

As requested by @Secrus in https://github.com/python-poetry/poetry/pull/9149#discussion_r1525588514.

abn avatar Mar 14 '24 23:03 abn

I don't understand. If there is code in tests/helpers.py that is not executed, just remove it already?

dimbleby avatar Mar 15 '24 20:03 dimbleby

No what are even supposed to do ?

DarkTechPirate avatar Mar 17 '24 17:03 DarkTechPirate

@dimbleby I think @Secrus is asking for test helpers to have functional test coverage. But yes, if we are not using a helper we should remove it. Although, I do not think that is the case right now.

abn avatar Mar 17 '24 21:03 abn

I dont buy it: who writes tests for their tests? what then, shall we write tests for the tests for the tests too?

test code automatically gets coverage by being executed in the test suite, else delete it

dimbleby avatar Mar 17 '24 23:03 dimbleby

I'll let @Secrus decide what they want to do with this one as I just created the issue based on his request. :wink:

abn avatar Mar 18 '24 22:03 abn

@Julynx you have completely misunderstood what is being discussed here

dimbleby avatar Apr 10 '24 06:04 dimbleby

@Julynx you have completely misunderstood what is being discussed here

Fair, I apologize for the misunderstading and I'm deleting my previous reply. Thanks for your patience.

Julynx avatar Apr 10 '24 06:04 Julynx