poetry icon indicating copy to clipboard operation
poetry copied to clipboard

ci: remove cache health check

Open mkniewallner opened this issue 3 years ago • 0 comments

Pull Request Check List

Cache is never reused on macOS because we use timeout to validate cache healthiness, but timeout is not available on macOS. So as the command fail, we execute the condition after || that deletes the virtual env, meaning we never use the cache on macOS (this can easily be seen here for instance).

I personally never came across a busted cache, so this PR suggests to remove the health check entirely (it is regularly updated anyway whenever there's a new Python patch version, or a dependencies update).

Alternatively, if you think that the health check is still necessary, removing the timeout could be enough, but I'd personally be onboard with removing the check entirely, and if we ever spot issues about busted caches, add it back.

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

mkniewallner avatar Sep 22 '22 21:09 mkniewallner