poetry icon indicating copy to clipboard operation
poetry copied to clipboard

chore(ci): check lock file consistency

Open mkniewallner opened this issue 3 years ago • 3 comments

Check lock file consistency on the CI, to ensure that poetry.lock is correctly updated on PRs updating dependencies in pyproject.toml.

This has been tested on my fork, with 2 cases:

Pull Request Check List

Closes: #6480

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

mkniewallner avatar Sep 13 '22 22:09 mkniewallner

This should probably be great to backport to 1.2 too, since there's a great chance that dependencies will get updated there too.

mkniewallner avatar Sep 13 '22 22:09 mkniewallner

I'd like to take a different approach with this as a pre-req for the main workflow. That being said, that would be part of the CI rework I'd like to PR -- do we want this right now, or can we wait a week or so for me to finish my PR?

neersighted avatar Sep 17 '22 15:09 neersighted

I'd like to take a different approach with this as a pre-req for the main workflow. That being said, that would be part of the CI rework I'd like to PR -- do we want this right now, or can we wait a week or so for me to finish my PR?

If this will be reworked soon, we might as well wait. We'll just need to carefully check on PRs that update dependencies that the lock file is correctly updated, in the meantime (a warning is shown during poetry install if lock file is not consistent).

mkniewallner avatar Sep 17 '22 15:09 mkniewallner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 29 '24 02:02 github-actions[bot]