poetry icon indicating copy to clipboard operation
poetry copied to clipboard

Backport caching improvements to 1.1 branch

Open maksbotan opened this issue 3 years ago • 5 comments

Pull Request Check List

This backports #4618 #2398 to 1.1 branch to fix related issues.

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

I took liberty to skip updating tests.

maksbotan avatar Aug 07 '22 19:08 maksbotan

CI seems to fail for reasons not related to my changes 🤔

maksbotan avatar Aug 07 '22 19:08 maksbotan

Hi. First of all, thank you for contributing to Poetry. However, since we are focusing on the 1.2 release, we won't be doing any more releases of version 1.1 (unless there are some breaking changes in 3rd party APIs like it was with 1.1.14). Backporting changes to an old version makes little sense since it probably will never be released.

Secrus avatar Aug 09 '22 17:08 Secrus

Thanks for the response! I'll stick with poetry-core from my git branch at work for now, as this speedup is critical for us. Combined, my four pull requests drop poetry lock --no-update from 7 minutes to just 3 seconds.

What is the release schedule for 1.2 branch? And can you please review my PRs that add new improvements to master?

Thanks.

maksbotan avatar Aug 09 '22 18:08 maksbotan

Thanks for the response! I'll stick with poetry-core from my git branch at work for now, as this speedup is critical for us. Combined, my four pull requests drop poetry lock --no-update from 7 minutes to just 3 seconds.

What is the release schedule for 1.2 branch? And can you please review my PRs that add new improvements to master?

Thanks.

https://github.com/python-poetry/poetry/issues/5586

We're working on catching up on reviews, but the last month has seen most of the team dealing with IRL priorities including health, work, and family -- we're still committed to getting this release out as soon as we are able, and to much smaller releases in the future to avoid similar pain.

neersighted avatar Aug 10 '22 16:08 neersighted

Thanks! I've subscribed to that thread.

maksbotan avatar Aug 10 '22 16:08 maksbotan

I will close this to reduce noise in PRs

Secrus avatar Aug 16 '22 09:08 Secrus

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 29 '24 09:02 github-actions[bot]