poetry
poetry copied to clipboard
python-poetry
Incomplete error message in exception
Pull Request Check List
Resolves: #5598
- [ ] Added tests for changed code.
- [ ] Updated documentation for changed code.
Hi @vighnesh-kadam seems that only tests is missing?, Are still interested in this PR?
Hi @vighnesh-kadam seems that only tests is missing?, Are still interested in this PR?
Yes I'm very much interested in completing this!! Last time i triee i was not able to clear the tests on ci/cd . Can you help me out with the next steps?
Well, I'm looking some points here. First of one, this change in the code should make some tests fails, but no tests fail. So the options are a) your change has not effect, or b) we need improve the tests. The second point to think is that the issue is talking about error message in general, not only the manage of the KeyRingError. I guess that the author of the issue used that KeyRingError just an example. So, I suppose that need more than one line to change.
Well, I'm looking some points here. First of one, this change in the code should make some tests fails, but no tests fail. So the options are a) your change has not effect, or b) we need improve the tests. The second point to think is that the issue is talking about error message in general, not only the manage of the KeyRingError. I guess that the author of the issue used that KeyRingError just an example. So, I suppose that need more than one line to change.
Sorry for the late reply , actually i wont be able to contribute to this and be active for a month or so due to personal commitments . Thank you for giving me thIs opportunity!!
@vighnesh-kadam are you still interested in finishing this?
Thank you for the opportunity!! But I won't be able to commit to this at the moment.
@Secrus do we really need a test case for a simple raise from? This feels a no-brain merge to me.
