poetry icon indicating copy to clipboard operation
poetry copied to clipboard

Fix problem with deleting temporary folders on Windows (re-created patch #1032)

Open eblis opened this issue 3 years ago • 5 comments

When deleting temporary directories on Windows try a few times so we get around a Windows error, see issue #1031 for more details.

Pull Request Check List

Resolves: #1031, #1032 Pull request #1032 is stale, but I took out the code from that and made the requested changes from comments (decreased timeout to 1s and added a test)

  • [x] Added tests for changed code.
  • [x] Updated documentation for changed code.

eblis avatar Feb 09 '22 09:02 eblis

Hi, @eblis are you still interested in bringing that to Poetry?

Secrus avatar May 21 '22 18:05 Secrus

If @eblis is not available then I am certainly interested, I've hit this issue several times now with our CI machines. What would need to be done? Is it just fixing the pre-commit checks?

da1910 avatar Aug 31 '22 10:08 da1910

Hey, sorry, I completely missed the updates in this issue. What do you need done ?

eblis avatar Aug 31 '22 12:08 eblis

It might be a matter of commenting pre-commit.ci autofix

Otherwise it'll need the checks fixing, see the failed check below

da1910 avatar Aug 31 '22 13:08 da1910

From what I can tell the relevant code has been moved to another repository called poetry-core.

eblis avatar Sep 03 '22 07:09 eblis

@Secrus We're approaching 2 months with the open PR from @eblis is there anything we can do to move the issue forward?

da1910 avatar Oct 31 '22 11:10 da1910

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 29 '24 03:02 github-actions[bot]