poetry-plugin-export icon indicating copy to clipboard operation
poetry-plugin-export copied to clipboard

make use of locked markers in lock file version 2.1 and thereby avoid `dependency walk failed`

Open radoering opened this issue 1 year ago • 4 comments

Resolves: #176 Resolves: #183 Requires: python-poetry/poetry#9427

With python-poetry/poetry#9427 we can fix dependency walk failed once and for all. The dependency walker becomes as simple as iterating over a flat list and doing some simple marker operations. There is no complicated erroneous logic anymore because the resulting markers for each locked package can be read from the lock file.

I adapted all tests so they are run with an old lock file without markers and with a new lock file with markers and added a test (at the end) that raises dependency walk failed for an old lock file and succeeds for a new lock file.

radoering avatar May 20 '24 13:05 radoering

This does resolve the long-standing issue with urllib3 for us: https://github.com/meltano/sdk/actions/runs/9358298538/job/25759841162.

edgarrmondragon avatar Jun 03 '24 22:06 edgarrmondragon

Very interested, we have been having issues with urllib3 as well

jbw-vtl avatar Jun 04 '24 08:06 jbw-vtl

Quality Gate Failed Quality Gate failed

Failed conditions
13.7% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 16 '24 11:06 sonarqubecloud[bot]

Hey! I'm not sure how this repository works. What would be needed to get this Pull Request going? It would be great to solve the longstanding #183

Alexander-Serov avatar Oct 22 '24 15:10 Alexander-Serov

Quality Gate Failed Quality Gate failed

Failed conditions
18.7% Duplication on New Code (required ≤ 12%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 23 '24 16:10 sonarqubecloud[bot]

What would be needed to get this Pull Request going?

It requires a Poetry release that includes https://github.com/python-poetry/poetry/pull/9427. That will be https://github.com/python-poetry/poetry/issues/9448.

radoering avatar Oct 23 '24 16:10 radoering