poetry-plugin-bundle icon indicating copy to clipboard operation
poetry-plugin-bundle copied to clipboard

Since 1.4 does not bundle into the specified directory

Open daniel-ferguson opened this issue 1 year ago • 1 comments

With version 1.3.0 I could run poetry bundle venv /path/to/venv and it would reliably bundle my project into that path.

With version 1.4.0 it seems to depend on whether Poetry is already managing a venv for the project...

Before I run poetry install then poetry bundle venv /path/to/venv works as expected. However after my first poetry install in the project poetry bundle /path/to/venv stops working as expected, and I get a log similar to this:

$ poetry bundle venv testvenv
  • Bundling poetry-plugin-bundle (1.4.0) into testvenv: Installing poetry-plugin-bundle (1.4.0)
Installing /Users/daniel/Library/Caches/pypoetry/virtualenvs/poetry-plugin-bundle-F9v3glxy-py3.12/lib/python3.12/site-packages/poetry_plugin_bundle-1.4.0.dist-info/METADATA over existing file
Installing /Users/daniel/Library/Caches/pypoetry/virtualenvs/poetry-plugin-bundle-F9v3glxy-py3.12/lib/python3.12/site-packages/poetry_plugin_bundle-1.4.0.dist-info/entry_points.txt over existing file
Installing /Users/daniel/Library/Caches/pypoetry/virtualenvs/poetry-plugin-bundle-F9v3glxy-py3.12/lib/python3.12/site-packages/poetry_plugin_bundle-1.4.0.dist-info/INSTALLER over existing file
  • Bundled poetry-plugin-bundle (1.4.0) into testvenv

It looks like its bundling it directly into the Poetry-managed virtualenv rather than the directory I specified.

I've tested this issue against two projects (some private code kicking around on my laptop, and against poetry-plugin-bundle itself).

Let me know if there are any further details I can provide to help track down the problem!


Poetry: 1.8.3 Operating System: OSX

daniel-ferguson avatar Jul 28 '24 19:07 daniel-ferguson

Probably caused by #103, which replaced build_venv() with create_venv(). Unfortunately, I will not have time to take a closer look within the next few weeks. Maybe, @BrandonLWhite can help.

radoering avatar Jul 29 '24 15:07 radoering

I will see if I can reproduce and determine what is going wrong.

BrandonLWhite avatar Jul 31 '24 16:07 BrandonLWhite

I've reproduced the issue, identified the root cause, and implemented a fix. I am still working on a suitable test however. Once I have that complete I'll open a PR.

BrandonLWhite avatar Aug 05 '24 14:08 BrandonLWhite

Hi I wanted to let you know that I am facing that exact same issue on version 1.4.1

francoisvogel avatar Nov 19 '24 10:11 francoisvogel

Version 1.7.0 + Poetry 2.1.2, this issue is still there and pretty relevant, it's basically the only reason why I'm using this package

lorenzomammana avatar Apr 22 '25 12:04 lorenzomammana