poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

Add monthly downloads badge to README

Open Aman-Clement opened this issue 1 year ago • 2 comments

Added a monthly downloads badge by pip Trends to the README. View more at - https://piptrends.com/widgets/poetry-core

Aman-Clement avatar Jun 24 '24 11:06 Aman-Clement

This person tried to open this exact PR against a project I'm the maintainer for as well (https://github.com/ixmatus/inflector/pull/16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi. I recommend rejecting this PR.

Users can get package statistics from libraries.io which is linked to directly by pypi itself.

ixmatus avatar Jun 26 '24 23:06 ixmatus

Yeah I don't see how this is better than shields.io:

PyPI - Downloads

edgarrmondragon avatar Jun 28 '24 22:06 edgarrmondragon

Thank you for your feedback and concerns. I'd like to clarify that this is not a promotional campaign. As stated in the PR description, our intention is simply to share a tool we have developed, which we believe could be beneficial to the community.

Our badge system offers highly accurate statistics, which is why we wanted to make it available. If the link to the pip trends page is a concern, we are more than willing to remove it.

We respect your decision if you prefer not to add more badges to your README. Our primary goal is to address any misunderstandings and assure you that this is a genuine effort to contribute to the open-source community by sharing our work on GitHub.

Thank you for considering our contribution.

ayushjain01 avatar Jul 01 '24 04:07 ayushjain01

Yeah I don't see how this is better than shields.io:

PyPI - Downloads

Here's how our badge is better than the existing badges - Sheilds.io - PyPI - Downloads pepy.tech - Downloads pip trends -poetry-core Downloads Last Month

You can see the difference in the download counts on all these badges. The pip trends badge count is the most accurate count and can be verified using -

SELECT COUNT(*) AS num_downloads
FROM `bigquery-public-data.pypi.file_downloads`
WHERE file.project = 'poetry-core'
  -- Only query the last 30 days of history
  AND DATE(timestamp)
    BETWEEN DATE_SUB(CURRENT_DATE(), INTERVAL 30 DAY)
    AND CURRENT_DATE()

You can read more and verify using this link - https://packaging.python.org/en/latest/guides/analyzing-pypi-package-downloads/#counting-package-downloads

ayushjain01 avatar Jul 01 '24 04:07 ayushjain01

Yeah, I don't think this is really needed, pass

Secrus avatar Jul 19 '24 19:07 Secrus