poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard
verified publisher icon python-poetry

Introduce wheel tag regex

Open rmarquis opened this issue 2 years ago • 1 comments

Resolves: python-poetry#3509

This is a follow-up of PR #227, based on the work of @jrandall rebased on latest stable version, squashed and cleaned up, with the addition of requested changes by @radoering.

As @jrandall is seemingly unresponsive, this is an attempt at getting his work merged in poetry-core. All credits to him.

As suggested in #227, the initial PR is divided in 2 parts:

  • fixing wheel tag determination (see #591)
  • introducing wheel-tag-regex (this PR)

This is based on PR #591, which would need to be merged first. I am unfortunately not sure about how to properly test with mocking of the proposed change, so this PR is in draft status at the moment. Any guidance is welcome here.

The first PR should actually fix most use cases, as this second PR is only needed for backward compatibility of older projects. New projects built with poetry should work properly with #591.

  • [x] Added tests for changed code.
  • [ ] Updated documentation for changed code.

rmarquis avatar May 19 '23 08:05 rmarquis

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 19 '23 08:05 sonarqubecloud[bot]