poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard
verified publisher icon python-poetry

fix: added 3.11 to list of available pythons

Open finswimmer opened this issue 3 years ago • 1 comments

Python 3.11 is just around the corner, so we have to update this list.

Package.AVAILABLE_PYTHONS is needed in two places:

  1. Adding a classifier when building a wheel (https://github.com/python-poetry/poetry-core/blob/4535724acb356a9da2fa976a243e5f63bef892f8/src/poetry/core/packages/package.py#L309)
  2. Finding a suitable interpreter when creating a venv (https://github.com/python-poetry/poetry/blob/2d09741ad67d4fabd94ce6ffd6257c5fec441c12/src/poetry/utils/env.py#L937)

I would prefer a more generic way. So if anyone has a suggestion ...

Downstream tests are fixed in https://github.com/python-poetry/poetry/pull/6561

finswimmer avatar Sep 19 '22 09:09 finswimmer

Shouldn't this list be updated to? https://github.com/python-poetry/poetry-core/blob/d6d33de68e48cd2da4730dd01b69b8d32f51ae41/src/poetry/core/version/helpers.py#L13-L26

mkniewallner avatar Sep 24 '22 16:09 mkniewallner

Shouldn't this list be updated to?

https://github.com/python-poetry/poetry-core/blob/d6d33de68e48cd2da4730dd01b69b8d32f51ae41/src/poetry/core/version/helpers.py#L13-L26

Good catch :+1:

finswimmer avatar Sep 25 '22 08:09 finswimmer

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 04 '22 16:10 sonarqubecloud[bot]