poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

packages: make hash() consistent and incl features

Open maksbotan opened this issue 3 years ago • 1 comments

This is a backport of 7e09102860b7e0b3f67bb9ba335dbecd2da56177 from master (PR #370).

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

As this is a backport to old branch that will never be merged to master, I took liberty to skip backporting tests. If you insist, I'll add them.

maksbotan avatar Aug 07 '22 19:08 maksbotan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 07 '22 19:08 sonarqubecloud[bot]

Sorry for the late response here -- core is not accepting backports to the previous branch given the imminent release of Poetry 1.2. Our new release strategy will require new releases of Poetry for core bumps anyway (since we're now pinning versions), and we will likely keep core compatible with the stable version of Poetry as well as the dev branch so that we don't maintain multiple versions.

neersighted avatar Aug 26 '22 08:08 neersighted

Thanks @neersighted!

Can I draw your attention to my other two PRs, that actually implement new functionality?

https://github.com/python-poetry/poetry/pull/6130 https://github.com/python-poetry/poetry/pull/6131

maksbotan avatar Aug 26 '22 08:08 maksbotan

I can try, but given we're in the final stages of 1.2's release that's where all energies are currently going. One of your PRs is likely to receive substantial feedback and/or a refactor from @radoering once his own related refactor lands.

neersighted avatar Aug 26 '22 09:08 neersighted

Thanks!

maksbotan avatar Aug 26 '22 09:08 maksbotan