poetry-core
poetry-core copied to clipboard
python-poetry
build: do not generate setup.py by default
This is the first step in removing setup file generation from Poetry
projects. With this change, projects that require a setup.py to be
generated when a build script is used needs to explicitly set
tool.poetry.build.generate-setup-file, introduced in #26, to true
in pyproject.toml.
References:
- #26
- https://github.com/python-poetry/poetry/issues/1338#issuecomment-657860111
Warning :warning: This is a breaking change for users relying on setuptools to run their build script without explicitly configuring the generation.
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
1.6% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@python-poetry/core @python-poetry/triage Would apprecaite feedback on this. We need to disable auto setup generation, this was originally planned for Poetry 1.2 as it was deprecated in Poetry 1.1.
I am fairly certain releasing this will break for a few folks building extensions using setuptools, just not sure how large the number is going to be.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
@abn I updated the PR, but this required deleting some code in test_complete.py. Could you check if that's fine?
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information