poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

lint and fix pep8 naming conventions

Open danieleades opened this issue 4 years ago • 6 comments

i'll see what the CI does, but i'm expecting there's a reasonable chance this is a breaking change for downstream

danieleades avatar Nov 16 '21 16:11 danieleades

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

neersighted avatar Nov 16 '21 17:11 neersighted

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

downstream tests passed. wasn't expecting that

danieleades avatar Nov 16 '21 17:11 danieleades

grepping the code, it's clear that the Exception class is used downstream. I guess the 'downstream' test case doesn't cover it.

I guess both repos will need to be changed together, and it's a major version bump for core

danieleades avatar Nov 16 '21 17:11 danieleades

rebased

danieleades avatar Nov 18 '21 15:11 danieleades

We could ignore the N818 error for now, to introduce pep-naming anyway.

finswimmer avatar Jan 24 '22 21:01 finswimmer

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 25 '22 08:01 sonarqubecloud[bot]