poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

Published 20 hours ago • verified publisher icon python-poetry

Fix unicode error

Open julienmalard opened this issue 3 years ago • 3 comments

This fixes #221 by exchanging the regex package for re (the former having fixed the long-standing bug in re (see here for details). Not sure if this will work for poetry (i.e., whether adding regex as a dependency is acceptable)...but thought I would propose this change and wait for feedback to take it from there. Thanks!

Resolves: https://github.com/python-poetry/poetry/issues/221

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

Unfortunately couldn't figure out where to add the tests. Let me know and I will gladly do so!

julienmalard avatar Feb 11 '21 15:02 julienmalard

Thank you for the PR! Can you rebase against main and resolve the conflicts?

kasteph avatar Mar 26 '21 14:03 kasteph

Thanks @stephsamson ! I rebased, added failing tests, and pushed again (all local tests passing with latest commit). Please do let me know what else would be needed.

julienmalard avatar Mar 26 '21 16:03 julienmalard

P.S. I just reformatted. It currently seems to fail because regex is missing as a dependency; do you happen to know where I should specify it? (Would adding it to [tool.poetry.dependencies] work?)

julienmalard avatar Mar 26 '21 17:03 julienmalard

Superseded by #276

Secrus avatar Aug 22 '22 08:08 Secrus