cleo icon indicating copy to clipboard operation
cleo copied to clipboard

Add PowerShell completion generation

Open ZettZet opened this issue 3 years ago • 4 comments

I'm not an expert in PowerShell or CLI's, but this developments may help someone else complete it Should be called like: script completions PowerShell > $PROFILE If I understand correctly, where PowerShell saves its configurations

Solves #253

ZettZet avatar Dec 19 '22 22:12 ZettZet

@ZettZet I'm interested in this, why was this not merged initially? Are there blocking points? If you highlight them I can try having a look at them for this PR to be merged.

Holt59 avatar Sep 29 '23 15:09 Holt59

@Holt59 Hi! Thanks for your attention; I appreciate it!

The two main blocking points are that this PR wasn't reviewed at all, and I'm not an expert in PowerShell or CLIs. I may not count some specific things about cleo and/or PowerShell. Therefore, it would be nice to look at this from another perspective, perhaps by people who do have experience in those spheres.

Feel free to review, test, and modify this PR. It will be perfect to complete it!

ZettZet avatar Sep 30 '23 16:09 ZettZet

From a maintainer's point of view: we are close to the 2.1 release, which will be the last 2.* release (unless something important, like a security issue happens). There is a plan for version 3.0, which will be a major overhaul of the whole library and internal workings of stuff, including completions. I left this PR open as a reference point for the future, but don't expect it to be merged "as is". Once we finalize the scope of changes for 3.0, I will revisit the Powershell completions topic and this PR as I want Cleo to include this capability.

Secrus avatar Oct 04 '23 10:10 Secrus

I did some more work on this PR in my fork: https://github.com/KotlinIsland/cleo/tree/add-powershell

KotlinIsland avatar Jan 15 '24 06:01 KotlinIsland

I did some more work on this PR in my fork: https://github.com/KotlinIsland/cleo/tree/add-powershell

KotlinIsland avatar Jan 15 '24 06:01 KotlinIsland