Pillow icon indicating copy to clipboard operation
Pillow copied to clipboard

Revert "Fix memory leak in TiffEncode"

Open wiredfool opened this issue 6 months ago • 2 comments

This reverts commit e2e40c54568236d2504921eb0b335cdab734a7d5.

Fixes https://github.com/python-pillow/Pillow/pull/8954#issuecomment-2929027106 .

Changes proposed in this pull request:

  • This reverts moving the cleanup for tiff encode into the cleanup function, as opposed to doing it in the actual encode
  • This is an intermittent issue on several of the platforms, it reasonably triggers using pytest -v --random-order Tests/test_file_libtiff.py on pypy3.10 on linux-x64
  • There's likely something else going on here, because the errors are on read and the changes are for write.

wiredfool avatar Jun 02 '25 09:06 wiredfool

I've created #9002 as a possible alternative.

radarhere avatar Jun 10 '25 13:06 radarhere

I saw that, I haven't had a chance to test it yet. Probably Friday.

wiredfool avatar Jun 12 '25 07:06 wiredfool

In the absence of any further discussion, I'll merge #9002 sometime in the next few days.

We're coming up on the release, and I would rather not merge it at the last minute.

radarhere avatar Jun 22 '25 11:06 radarhere

#9002 has ben merged.

radarhere avatar Jun 24 '25 23:06 radarhere