Missing Apache-2.0 notice for IcoImagePlugin

[stefan6419846]

What did you do?

Looked through the source code.

What did you expect to happen?

References to Apache-2.0 code contain the appropriate notice.

What actually happened?

The corresponding notice header is missing: https://github.com/python-pillow/Pillow/blob/main/src/PIL/IcoImagePlugin.py

In there, https://code.google.com/archive/p/casadebender/wikis/Win32IconImagePlugin.wiki is referenced, which is subject to the Apache-2.0 license:

Copyright 2008 Bryan Davis

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

[radarhere]

Would you like to create a pull request for this?

[stefan6419846]

Yes, I can have a look at this in the next days.

By the way: Having this Apache-2.0-licensed code (the Apache-2.0 license requires all derivatives of at least this file to keep the Apache-2.0 license) might have effects on the previous FreeType discussions in #8880 regarding the GPL-2.0-only as well. In the worst case, Pillow has always been incompatible to the GPL-2.0 due to this: https://www.gnu.org/licenses/license-list.html.en#apache2

This is a free software license, compatible with version 3 of the GNU GPL.

Please note that this license is not compatible with GPL version 2, because it has some requirements that are not in that GPL version. These include certain patent termination and indemnification provisions. The patent termination provision is a good thing, which is why we recommend the Apache 2.0 license for substantial programs over other lax permissive licenses.