Pillow icon indicating copy to clipboard operation
Pillow copied to clipboard

Windows Wheels from Christoph Gohlke Going Away Forever

Open wiredfool opened this issue 3 years ago • 8 comments

According to Christoph Gohlke, https://www.lfd.uci.edu/~gohlke/pythonlibs/ his lab has lost funding and the unofficial python wheels collection, and likely our official windows wheels, is going away before the end of next month.

wiredfool avatar Jun 15 '22 14:06 wiredfool

Funding for the Laboratory for Fluorescence Dynamics has ceased. This service will be discontinued before July 2022.

I'm very sorry to hear this. Thank you @cgohlke, for providing an invaluable service to the Python community for 12+ years. And thank you for all your work helping with Pillow too.

Do you think you'll be able to make a last set of Windows wheels for our July 1 release?

hugovk avatar Jun 15 '22 14:06 hugovk

End of an era, thanks @wiredfool for reporting and thank you @cgohlke for being there for Pillow since the beginning!! Not to mention dozens of other projects … 🙏

@hugovk We probably better figure something out sooner rather than later … can you or @wiredfool or @radarhere remind me how far we got on wheels doing it ourselves last time? Seems like we got close … let's keep rollin! rollin! rollin!

aclark4life avatar Jun 15 '22 14:06 aclark4life

@hugovk @cgohlke Maybe we can push the July release up a week or so if that would help… then we'd have 3 months or so to figure out something else assuming we don't need to do a bug fix release 🤞🤷

aclark4life avatar Jun 15 '22 15:06 aclark4life

We are actually building wheels on GitHub Actions for Windows (for example, see the "dist-main" link at https://github.com/python-pillow/Pillow/actions/runs/2495168122), but as I recall there's one or two things needed for them to be on par with the release ones.

@nulano, do you know what's needed?

@aclark4life We would also like to put out wheels for 3.11 beta, see https://github.com/python-pillow/Pillow/issues/6367, and need to check if multibuild is ready to do 3.11 for Linux/macOS.

(If we wanted to overhaul our wheel building, we could look at the newish https://github.com/pypa/cibuildwheel which can do wheels for all of Windows/Linux/macOS, but that's a bit longer term thing. That could also let us automate uploading releases to PyPI.)

hugovk avatar Jun 15 '22 15:06 hugovk

Do you think you'll be able to make a last set of Windows wheels for our July 1 release?

Sure.

cgohlke avatar Jun 15 '22 17:06 cgohlke

We are actually building wheels on GitHub Actions for Windows [...] but as I recall there's one or two things needed for them to be on par with the release ones.

IIRC the only thing missing was to check all dependencies are built with the same optimizations and optional dependencies enabled.

I'm pretty sure FreeType (and other font libs) was fine when I last checked, and zlib/libjpeg-turbo do not have dependencies themselves. The build explicitly disables OpenMP for ImageQuant, but that is not included in wheels anyway. The others build with their default configs (some patched to use /MD and the correct Windows SDK), so presumably should be fine as well.

Edit: I've looked through the dependency tree in https://github.com/python-pillow/Pillow/pull/6562#issue-1363965647.

nulano avatar Jun 16 '22 04:06 nulano

Dear @cgohlke, I sent you an Email regarding this topic. Kindly check it out, if you have time. Thank you!

yasamoka avatar Jun 17 '22 02:06 yasamoka

So is this then just a matter of updating the RELEASING checklist, to ensure that we are now using GitHub Actions? I've created PR #6458

radarhere avatar Jul 23 '22 05:07 radarhere

Pillow 9.3.0 has now been released - the first release with Windows wheels generated from GitHub Actions.

radarhere avatar Oct 30 '22 05:10 radarhere

Thanks very much to all involved in helping us make this transition.

radarhere avatar Oct 31 '22 03:10 radarhere