Pillow icon indicating copy to clipboard operation
Pillow copied to clipboard

Inline fname2char to fix memory leak

Open nulano opened this issue 3 years ago • 3 comments

Fixes #6319.

nulano avatar May 24 '22 15:05 nulano

I'm not sure what happened with valgrind, but there are no errors reported for the modified file.

==328== More than 10000000 total errors detected.  I'm not reporting any more.
==328== Final error counts will be inaccurate.  Go fix your program!
==328== Rerun with --error-limit=no to disable this cutoff.  Note
==328== that errors may occur in your program without prior warning from
==328== Valgrind, because errors are no longer being displayed.

The two failed tests are clearly unrelated:

FAILED Tests/test_file_pdf.py::test_redos[\r] - Failed: Timeout >1.0s
FAILED Tests/test_file_pdf.py::test_redos[\n] - Failed: Timeout >1.0s

nulano avatar May 24 '22 21:05 nulano

I'm not surprised that the redos ones might have failed, because the timeouts are probably calibrated for an ordinary run, not the 10x slower valgrind run.

wiredfool avatar May 24 '22 21:05 wiredfool

I've rerun valgrind and it is passing now.

radarhere avatar May 24 '22 23:05 radarhere