openapi-core icon indicating copy to clipboard operation
openapi-core copied to clipboard

p1c2u/openapi-core#296: Adds support for OpenAPI 3.1

Open nezhar opened this issue 4 years ago • 7 comments

This PR is build on top of:

  • https://github.com/p1c2u/openapi-schema-validator/pull/18
  • https://github.com/p1c2u/openapi-spec-validator/pull/128

Support for Python 3.6 is dropped as in the alpha release of jsonschema.

nezhar avatar Aug 30 '21 13:08 nezhar

Codecov Report

Merging #373 (4005f78) into master (51fa9cd) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          80       80           
  Lines        1824     1824           
  Branches      273      273           
=======================================
  Hits         1747     1747           
  Misses         57       57           
  Partials       20       20           
Impacted Files Coverage Δ
openapi_core/spec/shortcuts.py 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51fa9cd...4005f78. Read the comment docs.

codecov[bot] avatar Sep 01 '21 21:09 codecov[bot]

@p1c2u Could you please add your review?

tschmidtb51 avatar Jan 03 '22 10:01 tschmidtb51

Python 3.6 support drop can be extracted to separate commit/PR

p1c2u avatar Jan 19 '22 15:01 p1c2u

We need to add information about supported versions and how to use them to the README file

p1c2u avatar Jan 19 '22 15:01 p1c2u

Python 3.6 support drop can be extracted to separate commit/PR

Moved it to https://github.com/p1c2u/openapi-core/pull/383

nezhar avatar Jan 21 '22 16:01 nezhar

This is now using openapi-schema-validator==0.3.0a1 and openapi-spec-validator==0.5.0a1.

As openapi_v3_spec_validator is referencing to openapi_v31_spec_validator with the new alpha release, all tests for 3.0 specs need to explicitly define the spec_validator in the create_spec function.

Example:

from openapi_spec_validator import openapi_v31_spec_validator

spec = create_spec(
    spec_dict, spec_uri, spec_validator=openapi_v30_spec_validator
)

nezhar avatar Jan 28 '22 14:01 nezhar

@p1c2u are there any plans to continue with this or is it heading in a wrong direction? I'm asking, because since https://github.com/p1c2u/openapi-core/pull/393 was merged, there are a few things that need to be adapted in the PR.

nezhar avatar Mar 15 '22 08:03 nezhar

Closing in favor of #419

p1c2u avatar Sep 12 '22 16:09 p1c2u