microscope icon indicating copy to clipboard operation
microscope copied to clipboard

CoolLED out of date

Open dstoychev opened this issue 4 years ago • 1 comments

The CoolLED implementation seems out of date. It doesn't use the new trigger mixins, and it implements enable/disable methods directly instead of using _do_enable and _do_disable. There may be other issues as well. I think it needs to be reviewed and brought up-to-date.

dstoychev avatar Feb 18 '21 18:02 dstoychev

You're right that it implements enable and disable instead of _do_enable and _do_disable, but it does implement the TriggerTargetMixin. Are you sure you're looking at the latest master branch? This was done in 3d69829abc919

carandraug avatar Feb 20 '21 15:02 carandraug