microscope icon indicating copy to clipboard operation
microscope copied to clipboard

121 augmentor implementation

Open mickp opened this issue 5 years ago • 4 comments

Needs testing with hardware

An alternative implementation for #121, replacing #124.

The camera is augmented with methods to do data processing and return the correct image shape depending on processing mode. Camera parameters are passed as a dict, to avoid the dot-notation problem discussed in #124.

mickp avatar Jan 13 '20 15:01 mickp

@NickHallONBI - can you test this with the hardware when you get a chance?

mickp avatar Jan 13 '20 15:01 mickp

Testing today on the cryo Aurox setup appears to work.

One problem is the docstring..

Config sample: device(microscope.filterwheels.aurox.Clarity, {'camera': 'microscope.Cameras.cameramodule.SomeCamera', 'camera.someSetting': value})

The camera module is a python object not a string so shouldn't be in quotes.

iandobbie avatar Jan 30 '20 17:01 iandobbie

I started looking into this and merge into master but then noticed that while we import ClarityProcessor we then call clarity_process.ClarityProcessor. So has this actually been tested? What really have people been running?

carandraug avatar Sep 17 '20 15:09 carandraug

Exactly my question. We should merge what works and close the other issues.

iandobbie avatar Sep 17 '20 15:09 iandobbie