intelhex Check two IntelHex objects equality

Hi, I am looking for effective way of hex file data comparison, mainly equality check. Is there already some effective way of comparison?

Did you consider overriding of __eq__ ?

Mar 30 '22 12:03 diggit

~~Using equality check over output of segments() seems to work.~~ My second question remains.

Mar 30 '22 13:03 diggit

Due to internal data storage model there is no effective way for byte to byte comparison, that's actually O(n) operation.

Mar 30 '22 15:03 bialix

By "effective way", I meant something what does not have to repack data and do other unnecessary operations. Preferably in __eq__. O(n) is fine and probably expected.

Mar 31 '22 06:03 diggit

Unfortunately, internally it has to repack data for comparing.

Mar 31 '22 07:03 bialix

I peeked into sources and IntelHex._buf seems like dict of address->data. Equality comparison then would be just comparison of those dicts when taking account few other option (offset,...). Am I wrong?

Mar 31 '22 12:03 diggit

Yes, that's correct.

Mar 31 '22 13:03 bialix

Sorry, it seems I haven't thought enough about your question. So basically all you need is to compare this._buf to other._buf. Yep, that should be easy addition. Patches welcome, and please provide some tests.

~~Also, there is hexdiff.py script to compare two Intel Hex files, you might look into using it.~~ Actually, no, sorry.

Mar 31 '22 13:03 bialix