wsproto icon indicating copy to clipboard operation
wsproto copied to clipboard

Published 20 hours ago • verified publisher icon python-hyper

investigate why broken autobahn test is passing

Open njsmith opened this issue 7 years ago • 3 comments

Apparently the autobahn tests 12.5.* have a bug where they send invalid utf8:

https://github.com/aaugustin/websockets/pull/178#issuecomment-302923540 https://github.com/crossbario/autobahn-testsuite/issues/71

How can we be passing these tests? It seems like a correct implementation has to fail them.

njsmith avatar Jul 04 '17 06:07 njsmith

The answer is because we weren't running the test in question (12.4.5). Someone by the name of @njsmith decided that running up to 12.*.4 was fine. 🙂

jeamland avatar Jul 19 '17 03:07 jeamland

Ah-hah! How prescient of him.

njsmith avatar Jul 19 '17 04:07 njsmith

It looks like passing --cases all to run-autobahn-tests.py does check everything. I guess in theory we should run that occasionally, even if it's too heavy for doing as part of CI.

njsmith avatar Jul 19 '17 04:07 njsmith