hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Consider increasing flow control window size.

Open Lukasa opened this issue 10 years ago • 6 comments

65 kB runs the risk of blocking us. According to Patrick McManus, Firefox uses 256 MB by default, so we should consider going a bit higher (though probably not that high).

Lukasa avatar Mar 11 '15 09:03 Lukasa

How do we arrive on a good value?

  • Hyper uses 65536 B
  • Python3.4 and 2.7use 1048576 B

theSage21 avatar Jun 15 '15 06:06 theSage21

I think we should aim at somewhere between 65,535 (2**16) and 268,435,456 (2**28). A nice power of two is a good idea. If we can't think of anything better, 2**24 is the next round power of 2, giving us a flow control window size of 16MB.

Lukasa avatar Jun 15 '15 07:06 Lukasa

I am drawing a blank on all fronts. Should I change it to 2**24 while we hunt for solutions with solid theory behind them?

theSage21 avatar Jun 17 '15 03:06 theSage21

Yeah, let's use 2**24.

Lukasa avatar Jun 17 '15 07:06 Lukasa

Hi, i'm having this problem but i can't fix it, where should i increase flow control window size? I've tried setting it on network_buffer_size but still can not receive files bigger than 64k, and in the hyper library tried too

ramc88 avatar Oct 08 '16 20:10 ramc88

@ramc88 What specific problem are you having?

Lukasa avatar Oct 12 '16 12:10 Lukasa