pyro2 icon indicating copy to clipboard operation
pyro2 copied to clipboard
verified publisher icon python-hydro

[WIP] Setting the PPM advection problem

Open aisclark91 opened this issue 2 years ago • 4 comments

This PR, implements:

  • The PPM mesh reconstruction in the interface of the centered state.
  • The advection PPM numerical scheme.
  • An example on which the PPM numerical scheme operates on.
  • A Test that provides the validity of the numerical scheme.

Two more things remain:

  • To clean simulation.py and inherit as much as possible, and make soft links to the original advection problem folder.

aisclark91 avatar Apr 14 '23 05:04 aisclark91

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Apr 14 '23 05:04 review-notebook-app[bot]

I decided to clean the previous PR, since it contained many forced pushes. (I don't like the idea of pushing something that probably I shouldn't had). The advection PPM method now converges at second order as follows:

smooth_converge

aisclark91 avatar Apr 14 '23 06:04 aisclark91

Comparing the PPM vs PLM method, I have decided to compare the smooth problem using both methods, giving the following convergence result: smooth_converge

aisclark91 avatar Apr 14 '23 19:04 aisclark91

This PR is ready for review. One changed proposed by @simonguichandut was to include the PPM as an option in the advection problem, leaving different folders for different time integration schemes. I want to follow this approach in a separate PR.

aisclark91 avatar Aug 11 '23 14:08 aisclark91