python-gitlab icon indicating copy to clipboard operation
python-gitlab copied to clipboard

Project Runners Create - Already Exists GitlabCreateError error_message Property Type Dict Instead Of Str

Open mark-e-kibbe opened this issue 9 months ago • 1 comments

Description of the problem, including code/CLI snippet

p_runner = prj.runners.create({'runner_id': arguments.owned_runner_id})

Creating a project runner that already exists as attached will throw a GitlabCreateError exception, but the error_message propertty is of the wrong type (dict instead of str)

Per the documentation at: readthedocs, exception gitlab.GitlabCreateError(error_message: str | bytes = '', response_code: int | None = None, response_body: bytes | None = None)

Expected Behavior

GitlabCreateError error_message property should be type string when a duplicate runner id is attempted attached to a project

Actual Behavior

GitlabCreateError error_message property is type dict

Specifications

  • python-gitlab version: 4.1.1
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): 16.3

mark-e-kibbe avatar Nov 16 '23 19:11 mark-e-kibbe

Thanks @mark-e-kibbe, this sounds familiar, I think I've seen the same before somewhere else, so we might need to just add dict there as one of the possible types.

nejch avatar Nov 17 '23 08:11 nejch