gino icon indicating copy to clipboard operation
gino copied to clipboard
verified publisher icon python-gino

Moved `after_execute` after `async_execute`, added buggy `rowcount`

Open fantix opened this issue 7 years ago • 4 comments

Fixes #412

  • before_cursor_execute() and after_cursor_execute() is untouched - maybe we can create new events for async_execute() if needed by someone.
  • @wwwjfy any comments about the buggy rowcount please? It's not a public API so it should be fine in most cases.

fantix avatar Dec 19 '18 10:12 fantix

Pull Request Test Coverage Report for Build 1407

  • 63 of 64 (98.44%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 98.638%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gino/engine.py 17 18 94.44%
<!-- Total: 63 64
Totals Coverage Status
Change from base Build 1404: -0.005%
Covered Lines: 4057
Relevant Lines: 4113
💛 - Coveralls

coveralls avatar Dec 19 '18 10:12 coveralls

While I don't have a problem with the implementation (a bit hacky though), this situation makes me feel like it's a dilemma. SQLAlchemy is very popular that there are many tools built based on it, including db migration, web framework integration and profiler in this case. On one hand, I think we definitely should support those features, or at least expose interfaces for other packages to implement; on the other hand, those existing tools may already have many users who have got used to them, and it might be hard, even conflicting, to support all the synchronous libraries, as it's not the same way to think in sync and async. But, well, let's admit, inventing new tools takes a lot of time and effort, which can be hard for a full-time job, let alone for part-time maintainers.

I want to say no, but I can't give a solution to that, so I'll hope someday we can have a better, more async friendly solution.

(Sorry, I haven't checked what SQLTap does and how much effort to rebuild an async version.)

wwwjfy avatar Dec 19 '18 16:12 wwwjfy

Revisited this PR. I think rowcount will be useful in some cases. I'm not sure about the event part, as we already have #161 and #435. Do you want to have a more complete implementation instead?

wwwjfy avatar Mar 23 '19 09:03 wwwjfy

Oh yeah, I felt the same way as you did. A complete implementation would be nice, but I don't know how yet.

fantix avatar Mar 25 '19 02:03 fantix