Eel icon indicating copy to clipboard operation
Eel copied to clipboard

Fix WebSocket import error for Python 3.12 compatibility

Open philipdp123 opened this issue 1 year ago • 2 comments

This pull request addresses an issue encountered specifically in Python 3.12 related to importing the WebSocket extension in Bottle applications. The error arises due to the absence of the bottle.ext.websocket

Additionally I added tox configurations for Python 3.11 and Python 3.12

This PR should also resolve the following issues: #723

philipdp123 avatar Feb 22 '24 20:02 philipdp123

The solution should also be backwards compatible with other supported versions of python

philipdp123 avatar Feb 22 '24 20:02 philipdp123

It verry good

selltool avatar Mar 13 '24 09:03 selltool

@samuelhwilliams Can you please have a look at pulling this in for 3.12 support

philipdp123 avatar Jul 11 '24 14:07 philipdp123

Thanks for the nudge and sorry for the delay. This looks good - will merge.

samuelhwilliams avatar Jul 11 '24 21:07 samuelhwilliams

Thanks Samuel!

philipdp123 avatar Jul 12 '24 07:07 philipdp123