Off-load pyinstaller config to its hook

Open samuelhwilliams opened this issue 5 years ago • 2 comments

PyInstaller now has a custom hook for Eel (https://github.com/pyinstaller/pyinstaller-hooks-contrib/pull/6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this.

We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.

NOTE: We need to wait for a release of PyInstaller that includes the new hook.

Jun 21 '20 16:06 samuelhwilliams

Strong change

Jun 21 '20 17:06 ChrisKnott

https://github.com/pyinstaller/pyinstaller/releases/tag/v4.0 has been released now - update Eel for PyInstaller v4 and merge this.

Aug 09 '20 18:08 samuelhwilliams