site icon indicating copy to clipboard operation
site copied to clipboard

Subclassing context.md

Open Diabolical5777 opened this issue 2 years ago • 8 comments

Diabolical5777 avatar Mar 24 '22 09:03 Diabolical5777

Deploy Preview for pydis-static ready!

Name Link
Latest commit b6ec3f08c953ba7e4f865b6bdee9652d84aabbe0
Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/641a18cf6787400008b5647f
Deploy Preview https://deploy-preview-703--pydis-static.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Mar 24 '22 09:03 netlify[bot]

Coverage Status

Coverage: 100.0%. Remained the same when pulling 0cf7fc78f075bb46ca2d9b93922e5ffe522296a7 on Diabolical5777:subclassing_context.md into 58ef0e327f7a956a4d7220fa9e652bf01488befa on python-discord:main.

coveralls avatar Mar 24 '22 09:03 coveralls

Looks good to me! Though before this gets merged, you could implement some of Volccy's feedback.

Which ones? I thought I implemented them all

Diabolical5777 avatar Apr 12 '22 02:04 Diabolical5777

Looks good to me! Though before this gets merged, you could implement some of Volccy's feedback.

Which ones? I thought I implemented them all

I assumed since some of them weren't marked as resolved yet that they weren't completed, a mistake on my end haha

Shom770 avatar Apr 21 '22 21:04 Shom770

As per this message in the discord I will be taking over this PR.

Bluenix2 avatar Apr 22 '22 23:04 Bluenix2

Hey @Bluenix2, what's your status on this PR?

Thanks!

Xithrius avatar Jul 31 '22 19:07 Xithrius

I do not have any other changes - this is ready for review! The preview failed because of ratelimits, I am not sure whether I can re-run them.

Bluenix2 avatar Jul 31 '22 22:07 Bluenix2

Very cool. Thanks!

Xithrius avatar Jul 31 '22 22:07 Xithrius

Thanks for these reviews! I am hoping to get to this soon, sorry

Bluenix2 avatar Nov 24 '22 21:11 Bluenix2

Hey @Bluenix2 ! Don't mean to rush you, but what's your status on getting the reviews resolved? If you're unable to, we can make this up for grabs for someone else, no worries! Thanks 😄

Robin5605 avatar Dec 26 '22 02:12 Robin5605

wanted to rename the file for consistency, will need someone elses approval

wookie184 avatar Jan 14 '23 16:01 wookie184