sir-robin
sir-robin copied to clipboard
python-discord
AoC: Convert commands to hybrid slash commands (ephemeral where reasonable)
The following commands should be converting to hybrid slash commands:
- daystar
- leaderboard
- global leaderboard
- stats
- countdown (#101)
The following commands should be converted to slash-only and be ephemeral:
- connect/link
- disconnect/unlink
The following commands should only be able to be run in advent-of-code-bot-commands, sir-lancebot-playground, or bot-commands. If they are tried to run elsewhere, they should redirect to advent-of-code-bot-commands and let the user know.
- daystar
- leaderboard
- global leaderboard
- stats
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
Sure, how should I split the tasks?
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
Sure, how should I split the tasks?
@n0Oo0Oo0b I think splitting it up the same way Kat's done it should work. We could make PRs for each of them, so they can be reviewed more effectively. For instance, a PR titled Convert &daystar command into a hybrid command. This way we can get multiple people working on this issue at once as well
Seems like converting all of them in one go would be pretty straightforward (see https://github.com/python-discord/sir-robin/pull/101#issuecomment-1803742152), so I don't think it's necessary to split this issue up anymore.
@janine9vn just wanted to ask, what's the reasoning behind making only the link/unlink commands fully slash commands, and making the other hybrids?