sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard
Published 1 week ago • verified publisher icon python-discord

github command enhancements

Open onerandomusername opened this issue 4 years ago • 2 comments

Description

(Full list of changes is located on #778's review comments)

  • [ ] constants Some constants are unused, or not used well.
  • [ ] move ratelimits Ratelimits are only handled after a single call to fetch data, would make most sense to handle them in the fetch_data method
  • [ ] remove git alias while we're here, this should go as github is not git, and this allows future use of git as a command or tag.
  • [ ] add wait for deletion if a user wants to delete the embed, they will now be able to. In case they didn't mean to link the issues.
  • [x] include issue number in response With several issues requested, the issue numbers should be shown
  • [ ] move the if not message.guild check to before we scan for issues no reason to check for issues in a dm message, ever
  • [ ] https://github.com/python-discord/sir-lancebot/issues/1697
  • [x] keep the order the same issue order is currently converted to a set, which loses the initial order. Implemented in a previous refactor

Reasoning

General command enhancements, small performance boost. Most notably, only makes one request per pull instead of two.

Proposed Implementation

Implementation can be found on the review comments of #778

Would you like to implement this yourself?

  • [x] I'd like to implement this feature myself
  • [] Anyone can implement this feature

NOTE: This is stalled until #778 is merged

onerandomusername avatar Dec 03 '21 18:12 onerandomusername

New change:

As per this, https://canary.discord.com/channels/267624335836053506/635950537262759947/931292179744297010, github api can return a merged pr as still a draft for some ungodly reason, so the ordering of the emojis will be changed to support merged prs still being a draft..

onerandomusername avatar Jan 13 '22 21:01 onerandomusername

In case this hasn't been considered already, I think it would also be nice to be able to delete the embed with the issues/PR's if you type the wrong number by mistake. Or possibly a better idea is to have an edit listener so if you typed sir-lancebot#654 but you meant to type sir-lancebot#653, you could edit the message to say sir-lancebot#653 and that would automatically edit the embed with the new issue number.

Also, is this issue still being worked on? Seems to not have made any progress recently.

DMFriends avatar May 21 '22 20:05 DMFriends