sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Replace reactions in the `bookmark` command with buttons.

Open InvisibleOS opened this issue 3 years ago • 15 comments

Description

Right now, bookmarking messages as someone who is not the command invoker requires adding a reaction. I believe that the system can be made much more better using buttons as it greatly improves the UI and makes it a bit more simpler.

Reasoning

While using interactions, we now have an option to make any error only visible to the interaction author by making the error message ephemeral. This would mean that the error message will not be publicly visible and a confirmation message that is only visible to the interaction author can be sent as well.

Proposed Implementation

image

Additional Details

We can even make use of the link buttons and attach them to the bookmarked message. When clicked, they would redirect the user to the message. Adding a button for it would make the embed solely limited to the message content and a View Message link button would improve the UI as well as make navigation to the message a bit more easier.

Would you like to implement this yourself?

  • [x] I'd like to implement this feature myself
  • [ ] Anyone can implement this feature

InvisibleOS avatar Oct 30 '21 06:10 InvisibleOS

I'd like to see this happen too.

onerandomusername avatar Dec 13 '21 21:12 onerandomusername

I'd also add that this is a good time to edit the feedback message instead of deleting it after the timeout, so you have a trace of the invocation and not just nothing

Akarys42 avatar Dec 13 '21 21:12 Akarys42

Approved, and assigned! Good luck!

D0rs4n avatar Dec 14 '21 14:12 D0rs4n

I am extremely sorry to say but I currently have exams for a month due to which I will not be able to work on this. I had posted this sometime back when I had time but currently, my exams are right around the corner which is why I will not be able to work on this right now.

This can either be assigned to someone else or I can work on it from the 7th of January - whichever works (my exams end on the Jan 7th)

InvisibleOS avatar Dec 17 '21 11:12 InvisibleOS

I'm not sure what the priority is for this feature, but I don't think it's too high. Unless someone else comes along wanting to implement it, this will still be here in January.

onerandomusername avatar Dec 17 '21 15:12 onerandomusername

I'll add the up for grabs label, unless someone else takes it, you can go ahead and implement it in January. Good luck with your exams!

D0rs4n avatar Dec 17 '21 17:12 D0rs4n

Thank you very much!

InvisibleOS avatar Dec 19 '21 10:12 InvisibleOS

Can I request to be assigned?

Diabolical5777 avatar Jul 28 '22 04:07 Diabolical5777

@Diabolical5777 Yes.

Xithrius avatar Jul 28 '22 06:07 Xithrius

Just to confirm, the suggestion is simply to replace the current reaction for others receiving the bookmark to a button, right?

Diabolical5777 avatar Jul 28 '22 07:07 Diabolical5777

Yes.

Xithrius avatar Jul 28 '22 08:07 Xithrius

For the implementation of the button, I would ideally add the multiple arguments to the init of the view class and call the button with the arguments how it's being called currently, right?

Diabolical5777 avatar Jul 29 '22 06:07 Diabolical5777

For the implementation of the button, I would ideally add the multiple arguments to the init of the view class and call the button with the arguments how it's being called currently, right?

Yes, I think that sounds right. There are some examples of discord.py views with buttons here if that helps: https://github.com/python-discord/sir-robin/blob/e90d24072baf2dc57acd455e8a9d7e5d40457d46/bot/exts/code_jams/_views.py

wookie184 avatar Aug 17 '22 11:08 wookie184

Got it. Thanks

Diabolical5777 avatar Aug 17 '22 12:08 Diabolical5777

image Is using a button to be redirected to the bookmarked message in the user's DM's a good idea?

Diabolical5777 avatar Aug 18 '22 09:08 Diabolical5777