sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Porting CustomHelpCommand from `bot`

Open purefunctor opened this issue 5 years ago • 5 comments

Description

This proposes porting the CustomHelpCommand class from the server's Python Bot. This would mean either replacing the current implementation for SeasonalBot or extending it to fit the port.

Reasoning

Most command groups often make use of ctx.send_help like .snake or .cogs which don't utilize the help embeds. A common pattern that's used for this instead is to use ctx.invoke the help command explicitly like .caesarcipher. This would allow for the help responses for these command groups to be consistent with each other.

Proposed Implementation

The port should hopefully be a one-to-one copy of the original implementation, moving helper functions and adding a few adjustments for SeasonalBot.

Would you like to implement this yourself?

  • [ ] I'd like to implement this feature myself
  • [x] Anyone can implement this feature

purefunctor avatar Oct 01 '20 10:10 purefunctor

@PureFunctor are you still planning on implementing this, or do you think this is worthy of more discussion?

Xithrius avatar Mar 02 '21 07:03 Xithrius

I can't say I can work on this for now; I suppose further discussion might be needed in terms of the implications towards complexity or feature parity with the other bot.

purefunctor avatar Mar 02 '21 07:03 purefunctor

Thank you for the quick response. I hope everything works out in the end.

Xithrius avatar Mar 02 '21 07:03 Xithrius

This is now being ported to bot-core so that both bots can use the same code.

ChrisLovering avatar May 05 '23 11:05 ChrisLovering

I'll take care of this.

shtlrs avatar May 05 '23 12:05 shtlrs