sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

save a request in the github info cog when fetching pulls

Open onerandomusername opened this issue 3 months ago • 1 comments

Description

https://github.com/python-discord/sir-lancebot/blob/c8526d7935ee37389d10b03e833ccdeb2faa5101/bot/exts/utilities/githubinfo.py#L123-L125

This data is provided in the issue body under the pull_request key. We don't need to fetch a second time.

Reasoning

This will halve the requests used to look up a pull request, which stacks when looking up 2 or 3 pull requests at a time.

Proposed Implementation

Additional Details

Would you like to implement this yourself?

  • [x] I'd like to implement this feature myself
  • [ ] Anyone can implement this feature

onerandomusername avatar Sep 12 '25 17:09 onerandomusername

Sounds good to me!

ChrisLovering avatar Sep 12 '25 19:09 ChrisLovering