Option to send public valentines privately through DMs

[hedyhli]

Description

The bemyvalentine feature allows for valentines to either be secret/anonymous (sends the message to the selected user through DMs, without mentioning who it's from), or public by default (sends the message to #sir-lancebot-playground for everyone to see).

I would like for the non-secret mode to send valentines privately to the selected user in DMs, just like the secret mode.

The only difference would be that the valentine embed will include who the message is from.

Perhaps this can be made into an option for the user to choose whether to send it through DMs or to a public channel.

Proposed Implementation

So for the "normal" .bemyvalentine command, these two options:

1. Public Send the valentine message embed into the same channel as the command is invoked in. Currently, it forwards all valentine messages to #sir-lancebot-playground instead, which is away from where the .bemyvalentine command is invoked. I believe that if the embed is sent directly in that current channel conversation (whether that be serious or not) can remain in the same place, rather than having the user on the receiving end check for a ping in some other channel and refer back to where .bemyvalentine is invoked.

2. Private Send the message through DMs to the user. Same as .bemyvalentine secret, but reveals who the message is from in the embed. This allows people to make use of Sir Lancebot to send compliments/letters to another member without being anonymous, whilst having the whole ordeal remain private.

Reasoning

I love to send compliments to other members during the month of February as valentines. The person I send it to should want to know that it was I who sent it. (Actually, I just realized that if they're a mod, they can see the .bemyvalentine secret message Sir Lancebot deletes, right? right?! Ah, but I degress.)

Now sometimes, it isn't ideal for everyone to see those valentines messages in #sir-lancebot-playground if I choose to have the matter remain private among me and the person on the receiving end. Hence, it would be amazing if we implemented such an option for the user to choose whether the message would be sent publicly or private through DMs, for nonanonymous valentines.

---

Anyone can implement this feature

[jgyasu]

Hello, I would like to work on this issue. This would be my first time contributing to open-source so I would be grateful for some help.

[agussarsson]

Hello! We're a group of students from KTH DD2480, and we'd like to take on this issue. As far as I can tell there are no one assigned yet, would it be possible for me to get assigned?