sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Added "christmasify" avatar effect command.

Open SockYeh opened this issue 1 year ago • 5 comments

Relevant Issues

Closes #937

Description

  • Added "christmasify" command to add a Christmas touch to user's avatar.
  • Currently has 2 effects - Room for future additions
    • Make avatar chilly
    • Add ornaments

Did you:

SockYeh avatar Feb 21 '24 13:02 SockYeh

This looks great :)

Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

SockYeh avatar Feb 23 '24 18:02 SockYeh

This looks great :) Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

Reverse image search for ornaments_frame.png led me to this (among other similar looking websites). They've mentioned that they do not require attribution for non-commercial uses.

ice_frame.png can be found on freepik.com here and they've stated that they require attribution. (Also I do not see a .png download option but they do have .svg). It seems that the same author has also uploaded the image to shutterstock.

vivekashok1221 avatar Feb 23 '24 19:02 vivekashok1221

This looks great :) Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.

It was just downloaded from google so i have no clue where the source actually is 😅

Reverse image search for ornaments_frame.png led me to this (among other similar looking websites). They've mentioned that they do not require attribution for non-commercial uses.

ice_frame.png can be found on freepik.com here and they've stated that they require attribution. (Also I do not see a .png download option but they do have .svg). It seems that the same author has also uploaded the image to shutterstock.

that's great! What is the next step?

SockYeh avatar Feb 23 '24 19:02 SockYeh

Ideally we'd use assets that don't require attribution, since that's the easiest option where possible.

For ones that do require attribution, I think it's OK to put it in the command's help text.

wookie184 avatar Apr 16 '24 10:04 wookie184

I am unable to find images so would be grateful if someone could find one to add to the bot. Thanks.

SockYeh avatar Apr 25 '24 16:04 SockYeh