sir-lancebot
sir-lancebot copied to clipboard
"Christmas tree" holiday reaction reacts to just "tree"
Description
Certain links, specifically ones with ../tree/.., are reacted to with Christmas trees.
Steps to Reproduce
Send a link to a GitHub directory in a channel where the bot reacts.
Expected Behaviour
The bot to... not do that.
Actual Behaviour
Known Impacted Platforms
- [x] Web
- [x] Desktop
- [x] Android App
- [x] iOS App
Possible Solutions
Exclude links from being parsed for keywords.
Additional Details
Would you like to implement a fix?
Note: For high-priority or critical bugs, fixes may be implemented by staff.
- [ ] I'd like to implement the bug fix
- [x] Anyone can implement the bug fix
Here is the code in question: https://github.com/python-discord/sir-lancebot/blob/54d618da59e63936d6d9c6ab8fed5b325112289a/bot/exts/holidays/holidayreact.py#L64
It's matching on christams|tree
, so it will match on every tree, regardless of it's festivity. It'll even match on the Grinch's trees! This is obviously extremely worrisome, we don't want the Grinch anywhere near our festivities!! This is a MUST FIX issue!!!