sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Make deleting a bookmark a context menu command

Open shtlrs opened this issue 2 years ago • 5 comments

Closes #1196

The change is pretty similar to the bookmark one, and makes it more intuitive to delete a book mark straight from the DMs using a context menu command

shtlrs avatar Jan 29 '23 10:01 shtlrs

This might be better served with another application command, similar to how we changed the main bookmark command to one.

We can also deprecate the existing text command that way too.

If we make this delete command a global command, we can remove perms for people to run it in-server so it will only appear in DMs.

ChrisLovering avatar Feb 20 '23 23:02 ChrisLovering

we can remove perms for people to run it in-server so it will only appear in DMs.

Humm I see, just like the perms issue that happened for some people with the new bookmark command? That's a good idea.

shtlrs avatar Feb 21 '23 11:02 shtlrs

we can remove perms for people to run it in-server so it will only appear in DMs.

Humm I see, just like the perms issue that happened for some people with the new bookmark command? That's a good idea.

At a per command level you can control what users have permission to run it image

ChrisLovering avatar Feb 21 '23 11:02 ChrisLovering

That's neat.

Alright, sounds pretty good!

shtlrs avatar Feb 21 '23 11:02 shtlrs

That's neat.

Alright, sounds pretty good!

You can set it in-app using this

Setting an empty permissions field will disallow anyone except server administrators from using the command in a guild.

We'd likely still want a check to make sure a user isn't deleting a message in-guild though, just to be sure.

ChrisLovering avatar Feb 21 '23 11:02 ChrisLovering