sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Update the Hangman game

Open Diabolical5777 opened this issue 2 years ago • 5 comments

Description

In the hangman command, I think it would be nice if modes of "easy", "medium" and "hard" were added, instead of the 4 optional arguments it currently has.

Reasoning

It could make the game more flexible and easier to change it up

Proposed Implementation

By doing def hangman(self, ctx, *args)

Would you like to implement this yourself?

  • [x] I'd like to implement this feature myself
  • [ ] Anyone can implement this feature

Diabolical5777 avatar Aug 13 '22 09:08 Diabolical5777

I think having control over the config directly is quite useful.

So maybe instead we could have an additional optional param for difficulty. This param would set the "default" config for the game, but users could still give the existing params to overwrite that if needed.

IE you could do !hangman easy 4 which would set the min_length to 4 and the other variables to whatever would be considered "easy".

What do you think of that?

ChrisLovering avatar Aug 17 '22 10:08 ChrisLovering

Maybe...we can have both? The 3 modes added on to the current implementation of being able to have full control over the generated word? If we were to do def hangman(self, ctx, *args), we could check the len() passed in, and the type to figure out what the user inputted

Diabolical5777 avatar Aug 17 '22 11:08 Diabolical5777

Maybe...we can have both?

That's sort of what I was suggesting, with an additional optional param for difficulty.

However, rather than only allowing one or the other, I proposed that we would allow both if the user wanted, having the specific config overwrite the defaults for the difficulty.

ChrisLovering avatar Aug 17 '22 11:08 ChrisLovering

Would the amount of times that one of the 4 current optional arguments be a factor that affects the decision? As in, if most of the time, users just use the command without arguments

Diabolical5777 avatar Aug 17 '22 11:08 Diabolical5777

I want to do this issue, can I?

GiovanePS avatar Jul 07 '23 20:07 GiovanePS