sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Avoidance of `KeyError` from `"draft"` key when pulling GitHub PR data.

Open Xithrius opened this issue 3 years ago • 1 comments

Closes #928

We want to ensure the information received from GitHub is not malformed.

Due to this, FetchError handling has been moved to fetch_data function, so no placeholder variables in returns need to be used.

FetchError is no longer a data class, but an actual error which inherets from Exception.

Did you:

Xithrius avatar Jul 09 '22 22:07 Xithrius

Next, we need to add a cog error handler so raised FetchErrors are displayed to the users in a neatly formatted embed.

GDWR avatar Jul 09 '22 22:07 GDWR

@GDWR Would you like to take over this PR?

Xithrius avatar Aug 18 '22 23:08 Xithrius

Will finish this at a later time. Closing, since it'll become stale in the meantime.

Xithrius avatar Aug 30 '22 04:08 Xithrius