sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Minesweeper Unplayable

Open HassanAbouelela opened this issue 3 years ago • 2 comments

Description

PR #953 explicitly blocked all commands which run in DMs, but minesweeper was missed in testing. Minesweeper commands only work in DMs, which makes the game unplayable.

Steps to Reproduce

Try to play the minesweeper game using minesweeper start.

Expected Behaviour

You should be able to respond to the bot.

Actual Behaviour

The bot will tell you you lack permissions to use the game commands.

Known Impacted Platforms

  • [x] Web
  • [x] Desktop
  • [x] Android App
  • [x] iOS App

Possible Solutions

I see this being resolved in one of two ways:

  1. We make the game commands just a regular message listener like battleship does.
  2. or We tell the user to do it on the server. If we’re concerned with spam, we can delete their message after they send it.

Unless someone has a strong preference either way, I’ll leave this choice up to the person implementing the fix.

Would you like to implement a fix?

Note: For high-priority or critical bugs, fixes may be implemented by staff.

  • [ ] I'd like to implement the bug fix
  • [x] Anyone can implement the bug fix

HassanAbouelela avatar Jan 07 '22 12:01 HassanAbouelela

I think a reason that ms uses dms is because of Python's spam protection. It is somewhat easy to send a few commands to ms in very quick succession.

onerandomusername avatar Jan 07 '22 21:01 onerandomusername

the problem is we can't run minesweeper command on dms.

MaskDuck avatar Feb 22 '22 09:02 MaskDuck