bot icon indicating copy to clipboard operation
bot copied to clipboard

Revert to previous txt file deletion behavior

Open swfarnsworth opened this issue 1 year ago • 7 comments

Prior to the filtering system rewrite, if a user entered a message that was too long, the bot would delete the message and respond with this message in the channel where the deleted message was posted.

image

The current behavior is that the bot will send a direct message to the user.

Anecdotally, the current behavior seems to be less effective. I frequently see people try to post the same message multiple times and complain that the bot keeps deleting their message, without the user seeing or acting upon the direct message from the bot.

We should revert to the previous behavior of sending a message in the channel where the long message (or txt file) was posted.

swfarnsworth avatar Dec 18 '23 16:12 swfarnsworth

is this being worked on, or can I work on it?

Esther-Goldberg avatar Apr 08 '24 03:04 Esther-Goldberg

Doesn't look like anyone has assigned to this issue yet, I will assign you now!

jb3 avatar Apr 08 '24 04:04 jb3

It looks like the current filtering system doesn't have a setting to send embeds in the original channel, so that would have to be added

Esther-Goldberg avatar Apr 08 '24 04:04 Esther-Goldberg

assuming we also want this for .py files

Esther-Goldberg avatar Apr 08 '24 04:04 Esther-Goldberg

Yeah some setting(s) needs to be added here.

I'm wondering what the correct approach here is: We could have a setting for whether to DM the message or send it in the public channel (in which case it might make sense to change the names of dm_content and dm_embed since it wouldn't necessarily be a DM anymore), or we could add a setting that allows sending the message publicly as a fallback if sending the DM fails (usually because they have DMs off).

mbaruh avatar Apr 09 '24 07:04 mbaruh

People don't necessarily check their DMs in the middle of using a help channel, so in this case we probably want to put an embed in the channel even if they have DMs open.

Esther-Goldberg avatar Apr 09 '24 13:04 Esther-Goldberg

Yeah that makes sense

mbaruh avatar Apr 09 '24 18:04 mbaruh