bot icon indicating copy to clipboard operation
bot copied to clipboard

`/tag` command output bugs

Open TizzySaurus opened this issue 2 years ago • 4 comments

When executing the command /tag without any arguments, a list of all tags is displayed. However, for some reason there's a random bullet point at the top of the list: Screenshot 2023-05-07 at 14 04 15

Similarly, when the "Did you mean" message comes up for a non-exact multi-match, such as /tag name:f-str, the "Did you mean ..." has a space before the ... that shouldn't be there: Screenshot 2023-05-07 at 14 13 53

The relevant lines of code appear to be here and here, although I've not delved too deeply into the code so this could be wrong.

TizzySaurus avatar May 07 '23 13:05 TizzySaurus

It's because of tag groups, https://github.com/python-discord/bot/issues/1545, we don't have any tag groups yet, so all tags are under the default group which has no name, hence is just a bullet point. Related: https://github.com/python-discord/bot/issues/2423

wookie184 avatar May 07 '23 16:05 wookie184

I would like to work on this issue.

SamantaTarun avatar May 07 '23 18:05 SamantaTarun

@tarunsamanta2k20 hey, are you stilling working on this ?

RohanJnr avatar May 18 '23 06:05 RohanJnr

These are some of changes we should be doing:

  • Change the tag embed footer to remove prefix and use / image

  • We need better help message to tell users on how to use tags from a group. Currently, the syntax to view a tag from a group is /tag name:<group_name> <tag_name>, this has to be mentioned in the tag help message. image

  • We could also change the slash command auto complete to show tags under groups and invoke them by just selecting it from the suggested items. Currently, only tag names outside groups are shown

RohanJnr avatar May 18 '23 07:05 RohanJnr

An update on the points proposed in the issue:

  • [x] Empty bullet (#3011)
  • [x] "Did you mean ..." (#3011)
  • [x] Tag embed footer (#2987)
  • [ ] Extra aliases in tag suggestions

@RohanJnr, regarding improving the docs for /tag -- although we don't actually have any tag groups yet, I agree it could perhaps be made clearer. I've opened a separate issue for it since this is unrelated to the /tag output in this issue. (#3014)

Now it looks like the aliases cluttering already have an issue of its own: #2345. So I'll close this issue since everything mentioned has been addressed.

hedyhli avatar Apr 13 '24 05:04 hedyhli