bot icon indicating copy to clipboard operation
bot copied to clipboard

Change behavior of `newlines` rule (pending the new filter system)

Open minalike opened this issue 3 years ago • 9 comments

Currently, the newlines rule triggers a ping to Moderators, deletes the offending message and also mutes the offending user.

This is commonly triggered by people seeking help, often in help channels or topical channels.

Let's discuss whether we can:

  • prevent bot from muting the user, instead have it reply with a reason for message deletion and a link to our pastebin service
  • not have the user muted
  • not ping Moderators
  • not relay to #mod-alerts
  • possibly still mute the user if they trigger newlines a certain number of times in a given timeframe?

If the above can be implemented, I imagine that discussions and help sessions can continue smoothly without a moderator having to step in to unmute the user, and invoke !paste with an explanation.

minalike avatar Dec 13 '21 02:12 minalike

What's the current new line rule, how many lines are needed to trigger the filter? Perhaps it could be changed slightly, to not trigger so easily?

onerandomusername avatar Dec 13 '21 03:12 onerandomusername

What's the current new line rule, how many lines are needed to trigger the filter? Perhaps it could be changed slightly, to not trigger so easily?

I don't think that could be done without making the whole filter pointless, or at least less effective, as it's often over 100 newlines already (the times it's triggered that is, I don't know what the limit is).

dawnofmidnight avatar Dec 13 '21 03:12 dawnofmidnight

Ah, that makes sense.

onerandomusername avatar Dec 13 '21 03:12 onerandomusername

I was able to find this, the limit is already 100 lines, so my point may be invalid. https://github.com/python-discord/bot/blob/a5cfe2ac47077805c205bcaf05eaed5ded5d09f9/config-default.yml#L439-L442

dawnofmidnight avatar Dec 13 '21 03:12 dawnofmidnight

I was able to find this, the limit is already 100 lines, so my point may be invalid.

https://github.com/python-discord/bot/blob/a5cfe2ac47077805c205bcaf05eaed5ded5d09f9/config-default.yml#L439-L442

Depending on how the messages trigger it, it may be possible to increase max, but keep max_consecutive the same.

onerandomusername avatar Dec 13 '21 03:12 onerandomusername

So it seems like there are still some modifications, and I do understand this a bit more, but I think that increasing the max newlines a bit might help in the short term.

We could also add a bit more complexity, by calculating the max characters and a percentage of which of those characters were newlines vs whitespace.

onerandomusername avatar Dec 15 '21 22:12 onerandomusername

Example of an instance where it took us 8 minutes to unmute someone that triggered the newlines rule while getting help in a help session.

minalike avatar Jan 11 '22 15:01 minalike

The simplest solution is probably just to grant forgiveness to a single-message newlines violation per ~hour, along with a link to the pastebin etc.

camcaswell avatar May 23 '22 04:05 camcaswell

Everything detailed in the OP is now possible except for the last one, which shouldn't be difficult to implement. What this really needs though is a moderation team discussion.

mbaruh avatar Apr 09 '23 17:04 mbaruh