Patreon

[mathstrains21]

Closes #1765

First off, this is my first pull request so please give me general pull request feedback if you have any :-)

Some decisions have been made on discord. A search of bot#1765 should find you all the conversations.

Some changes to make to test:

• Create 3 new roles, with clear different colours so you can see colours on embeds!
• Put these in your config.yml

There are 2 new commands: !patrons and !patreon. These send the list of patrons and some patreon info respectively.

Logging

I have not included an logging. Please provide feedback about logging.

[mathstrains21]

I would also like a review from @ChrisLovering - cannot work out how to request a review from you though :-)

[mathstrains21]

Most suggestions from @TizzySaurus fixed. Left 2 due to pending conversation / work to be done elsewhere.

[mathstrains21]

I've only tested it quickly so this is mainly a code review (although it seems to work nicely, I like the embeds!)

Firstly, thanks for the PR! The structure of the code seems good and it's been written well.

My main comments here are about repetition, there are couple of places where I think using loops would neaten the code up a bit, making it a bit more concise and extensible. That said, these aren't required changes, i've only mentioned them as something to think about if you want to.

Have had a look at your review and made a few comments. Will probably have a better look and see about implementing some of this tomorrow when my brain is less tired and other people have had a chance to give some ideas relating to your suggestions!

[Xithrius]

@mathstrains21 will you be continuing this PR?

[mathstrains21]

@mathstrains21 will you be continuing this PR?

Hi! I will be, I just need to find the time to do so! Thanks for the reminder though!

[Xithrius]

Thanks for the quick update! Have a good one!

[Xithrius]

@mathstrains21 Hey, it's been a while. What's your status on this PR? Thanks!

[Xithrius]

@mathstrains21 how's it going?

[wookie184]

I'll finish this one off

[wookie184]

will have to open a new PR I think

[mathstrains21]

I don't have time to continue right now, but would you like access to my repo to keep it in one PR?

[wookie184]

I don't have time to continue right now, but would you like access to my repo to keep it in one PR?

That would be helpful, thanks!

[wookie184]

This is now ready for review

[onerandomusername]

Please remove my request for review.

[wookie184]

I've also taken the liberty of adding the 3 patreon roles to the test server and updating the config.yml in notion.

Thanks, I definitely did not forget those were things that would need to be done :P

[mathstrains21]

Thanks @wookie184 for finishing this off for me!