babel icon indicating copy to clipboard operation
babel copied to clipboard

Use canonical IANA zone names in zone_territories

Open akx opened this issue 6 months ago • 3 comments

Refs #1218, should fix it.

There's an iana="..." attribute in (at least recent) timezone XML files, but we historically never read that and instead just trusted the first alias to be the canonical tzid.

akx avatar Jul 08 '25 10:07 akx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.97%. Comparing base (69c5db8) to head (e7f6feb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files          27       27           
  Lines        4688     4688           
=======================================
  Hits         4312     4312           
  Misses        376      376           
Flag Coverage Δ
macos-14-3.10 91.01% <ø> (ø)
macos-14-3.11 90.95% <ø> (ø)
macos-14-3.12 91.16% <ø> (ø)
macos-14-3.13 91.16% <ø> (ø)
macos-14-3.8 90.88% <ø> (ø)
macos-14-3.9 90.94% <ø> (ø)
macos-14-pypy3.10 91.01% <ø> (ø)
ubuntu-24.04-3.10 91.04% <ø> (ø)
ubuntu-24.04-3.11 90.97% <ø> (ø)
ubuntu-24.04-3.12 91.19% <ø> (ø)
ubuntu-24.04-3.13 91.19% <ø> (ø)
ubuntu-24.04-3.8 90.90% <ø> (ø)
ubuntu-24.04-3.9 90.97% <ø> (ø)
ubuntu-24.04-pypy3.10 91.04% <ø> (ø)
windows-2022-3.10 91.03% <ø> (ø)
windows-2022-3.11 90.96% <ø> (ø)
windows-2022-3.12 91.18% <ø> (ø)
windows-2022-3.13 91.18% <ø> (ø)
windows-2022-3.8 91.00% <ø> (ø)
windows-2022-3.9 90.96% <ø> (ø)
windows-2022-pypy3.10 91.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 08 '25 10:07 codecov[bot]

@anentropic Please review if you have time :)

akx avatar Jul 08 '25 10:07 akx

the results in test_core look good to me 👍

anentropic avatar Jul 13 '25 16:07 anentropic