babel icon indicating copy to clipboard operation
babel copied to clipboard

Apply reformatting by hand and with Ruff

Open akx opened this issue 10 months ago • 1 comments

This PR updates Ruff, configures the target line-length to 95 (strikes a balance between the current line lengths in the repo and readability), and formats babel/.

Some artful # fmt: skips, as well as very minor refactoring was done to keep things more readable.

Tests are unformatted in this PR to prove that there are no functional changes in the babel/ code, so as to make this easy to review.

A future PR will likely reformat tests/ similarly, and enforce formatting in CI.

akx avatar Mar 17 '25 14:03 akx

Codecov Report

Attention: Patch coverage is 89.21569% with 22 lines in your changes missing coverage. Please review.

Project coverage is 92.10%. Comparing base (de44e18) to head (859ba8d). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
babel/dates.py 68.75% 10 Missing :warning:
babel/messages/checkers.py 60.00% 2 Missing :warning:
babel/messages/frontend.py 92.85% 2 Missing :warning:
babel/core.py 91.66% 1 Missing :warning:
babel/localtime/_win32.py 0.00% 1 Missing :warning:
babel/messages/catalog.py 94.11% 1 Missing :warning:
babel/messages/extract.py 94.11% 1 Missing :warning:
babel/messages/pofile.py 92.30% 1 Missing :warning:
babel/numbers.py 96.15% 1 Missing :warning:
babel/support.py 93.75% 1 Missing :warning:
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
+ Coverage   91.98%   92.10%   +0.11%     
==========================================
  Files          27       27              
  Lines        4693     4685       -8     
==========================================
- Hits         4317     4315       -2     
+ Misses        376      370       -6     
Flag Coverage Δ
macos-14-3.10 91.14% <89.21%> (+0.11%) :arrow_up:
macos-14-3.11 91.07% <89.21%> (+0.11%) :arrow_up:
macos-14-3.12 91.29% <89.21%> (+0.11%) :arrow_up:
macos-14-3.13 91.29% <89.21%> (+0.11%) :arrow_up:
macos-14-3.8 91.00% <89.21%> (+0.11%) :arrow_up:
macos-14-3.9 91.07% <89.21%> (+0.11%) :arrow_up:
macos-14-pypy3.10 91.14% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.10 91.16% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.11 91.09% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.12 91.31% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.13 91.31% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.8 91.02% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-3.9 91.09% <89.21%> (+0.11%) :arrow_up:
ubuntu-24.04-pypy3.10 91.16% <89.21%> (+0.11%) :arrow_up:
windows-2022-3.10 91.15% <88.72%> (+0.11%) :arrow_up:
windows-2022-3.11 91.08% <88.72%> (+0.11%) :arrow_up:
windows-2022-3.12 91.30% <88.72%> (+0.11%) :arrow_up:
windows-2022-3.13 91.30% <88.72%> (+0.11%) :arrow_up:
windows-2022-3.8 91.12% <88.72%> (+0.11%) :arrow_up:
windows-2022-3.9 91.08% <88.72%> (+0.11%) :arrow_up:
windows-2022-pypy3.10 91.15% <88.72%> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 18 '25 07:03 codecov[bot]